librdkafka: expose retry and reconnect backoff settings #33973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykulma
force-pushed
the
maz-expose-kafka-backoff-params
branch
from
fa67352 to
90c92ba
Compare
martykulma
changed the title
def-
reviewed
Nov 11, 2025
| "kafka_retry_backoff", | ||
| "kafka_retry_backoff_max", | ||
| "kafka_reconnect_backoff", | ||
| "kafka_reconnect_backoff_max", |
Contributor
There was a problem hiding this comment.
Doesn't hurt to have them configurable in tests?
Contributor
Author
There was a problem hiding this comment.
I didn't think this prevented configuration in tests. My understanding is that these can still be set via additional_system_parameter_defaults or ALTER SYSTEM SET, if needed.
I put them in this list because they didn't seem to belong in the other camps (per the comment). We set reasonable defaults in the code. Testing variations of retry backoff settings seems unlikely to bear any fruit as far as meaningful bugs.
teskje
approved these changes
Nov 14, 2025
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
I have no context on these options, but seems straightforward enough!
- set default reconnect backoff max to 30s
martykulma
force-pushed
the
maz-expose-kafka-backoff-params
branch
from
90c92ba to
bfcc9a6
Compare
Contributor
Author
TFTR @teskje! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes librdkafka settings as system settings:
retry.backoff.msretry.backoff.max.msreconnect.backoff.msreconnect.backoff.max.msMZ will provide the default values, most of which are set based on the current defaults described here.
I increased the default value for
reconnect.backoff.max.msto30sbased on local testing.librdkafkawould have tried reconnecting a few times quickly before reaching the30stime. If those didn't work, it's likely that the cause is longer lived. Happy to set this to the librdkafka default of10sif folks disagree.Motivation
exposes settings to help alleviate https://github.com/MaterializeInc/database-issues/issues/9801
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.